Add maxResults parameter and return text results by default #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid errors like: Error: MCP tool "find_code" response (194537 tokens) exceeds maximum allowed tokens (25000). Please use pagination, filtering, or limit parameters to reduce the response size.
There was a problem hiding this comment.
Pull Request Overview
This PR adds maxResults parameter and text output format support to prevent token limit errors that could occur when using the MCP server. The changes introduce pagination capabilities and a more token-efficient text format alongside the existing JSON format.
Key changes:
- Added
max_resultsparameter tofind_codeandfind_code_by_rulefunctions - Added
output_formatparameter with "text" as default (more token-efficient) and "json" options - Added comprehensive unit and integration tests with CI workflow
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| main.py | Added pagination parameters and text output format to core search functions |
| tests/test_main.py | Comprehensive unit tests for all MCP server functions with mocking |
| tests/test_integration.py | Integration tests using actual fixture files |
| tests/fixtures/example.py | Test fixture with Python code examples |
| pyproject.toml | Added development dependencies and testing configuration |
| .github/workflows/test.yml | CI workflow for cross-platform testing |
| README.md | Updated documentation for new parameters |
main.py
Outdated
| output = '\n'.join(non_empty_lines) | ||
| header = f"Found {len(non_empty_lines)} matches (limited to {max_results}):\n" | ||
| else: | ||
| header = f"Found {len(non_empty_lines)} matches:\n" |
There was a problem hiding this comment.
similarly, the header can be omitted.
main.py
Outdated
| # Limit the results | ||
| non_empty_lines = non_empty_lines[:max_results] | ||
| output = '\n'.join(non_empty_lines) | ||
| header = f"Found {len(non_empty_lines)} matches (limited to {max_results}):\n" |
There was a problem hiding this comment.
This can be a single line of "Showing the {max_len} lines of results"
sebthom
force-pushed
the
maxResults
branch
2 times, most recently
from
bbe75e6 to
34b4335
Compare
HerringtonDarkholme
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid errors like:
The first commit b28e40d addresses the problem.
The second commits 805bd67 adds tests and a CI workflow for the mcp tools.